Add CompletableFuture and CompletionStage accessors to ReactiveResponseConsumer#598
Open
arturobernalg wants to merge 3 commits intoapache:masterfrom
Open
Add CompletableFuture and CompletionStage accessors to ReactiveResponseConsumer#598arturobernalg wants to merge 3 commits intoapache:masterfrom
arturobernalg wants to merge 3 commits intoapache:masterfrom
Conversation
Expose response and exchange completion as CompletableFuture for easier non-blocking integration.
Expose response and exchange completion as CompletionStage views of existing CompletableFutures.
arturobernalg
changed the title
ok2c
reviewed
Jan 17, 2026
httpcore5-reactive/src/main/java/org/apache/hc/core5/reactive/ReactiveResponseConsumer.java
Outdated
Show resolved
Hide resolved
…ilure cause or null on success.
arturobernalg
force-pushed
the
CompletableFutureReactive
branch
from
31d9777 to
95b07a9
Compare
Member
|
@arturobernalg You are at @rschmitt mercy here. |
Contributor
|
I don't know what to make of all this. What problem are you trying to solve? |
Member
Author
This does not change I/O behavior; it only exposes existing completion milestones as CompletionStage to avoid blocking Future#get() / callback glue and to make cancellation/shutdown explicit. |
Member
|
@rschmitt I imagine this could be useful to users but this is your call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose response availability, exchange completion, and terminal failure as CompletionStage backed by CompletableFuture.